r-lib / pkgbuild

Find tools needed to build R packages
https://pkgbuild.r-lib.org
Other
66 stars 35 forks source link

debug should also be taken into account with Rtools 4.0 #104

Closed cderv closed 4 years ago

cderv commented 4 years ago

Currently, no debut print is done when using

library(pkgbuild)
pkgbuild:::is_R4()
#> [1] TRUE
find_rtools(TRUE)
#> [1] TRUE

Created on 2020-09-16 by the reprex package (v0.3.0.9001)

With this PR

pkgload::load_all()
#> Loading pkgbuild
pkgbuild:::is_R4()
#> [1] TRUE
find_rtools(TRUE)
#> Found in Rtools 4.0 installation folder
#> [1] TRUE

Created on 2020-09-16 by the reprex package (v0.3.0.9001)

The message could be more precise like "Using R >=4.0 and Rtools founds in installation folder (default or set by RTOOLS40_HOME)"

jimhester commented 4 years ago

I think it is fine as you have it, thanks!

Thanks a million!