search

r-lib / pkgbuild

Find tools needed to build R packages
https://pkgbuild.r-lib.org
Other
65 stars 33 forks source link

Can we propagate build warnings to errors #114

Closed krlmlr closed 1 year ago

krlmlr commented 3 years ago

at least for devtools::release()?

Use case: a stray testthat-problems.Rds causes R CMD build . to increase (!!!) the version number in DESCRIPTION to 3.5 instead of failing the build. This is very easy to go unnoticed. Can we make this a failure here?

Related: https://github.com/r-lib/testthat/pull/1292.

It's an entirely different discussion if R CMD build . should ever touch my DESCRIPTION.

gaborcsardi commented 2 years ago

This seems hard, because R CMD build runs in a separate process, and the exit status is still zero if it bumps the version number.