r-lib / pkgbuild

Find tools needed to build R packages
https://pkgbuild.r-lib.org
Other
66 stars 35 forks source link

Fix rtools_needed always returning custom #98

Closed burgerga closed 4 years ago

burgerga commented 4 years ago

Because the 'custom' entry in version_info has quite a large range and is checked first, rtools_needed always returned 'custom'. (as discussed in #97)

This fix:

All checks pass!

jimhester commented 4 years ago

Thanks! Can you please add a bullet to NEWS? It should briefly describe the change and end with (@yourname, #issuenumber).

burgerga commented 4 years ago

Done! (and rebased)

jimhester commented 4 years ago

Thanks!

Thank you!