version_tooltip doesn't seem to work as expected.

r-lib / pkgdown

Generate static html documentation for an R package

https://pkgdown.r-lib.org/

Other

708 stars 323 forks source link

version_tooltip doesn't seem to work as expected. #2692

Open olivroy opened 2 weeks ago

olivroy commented 2 weeks ago

I found one notable usage in the wild: the data.table package

https://github.com/Rdatatable/data.table/blob/master/_pkgdown.yml

However, the tooltip doesn't appear on their website. https://rdatatable.gitlab.io/data.table/

I couldn't find a way to make it work.

I tried to set it for tmap, https://github.com/r-tmap/tmap/commit/5568c3d156626e7308309269068f079affe218ef

but still shows the default in https://r-tmap.github.io/tmap/dev/

jayhesselberth commented 2 weeks ago

It looks like the setting in the config file isn't respected, set here:

https://github.com/r-lib/pkgdown/blob/812e8c81d2a550f11f1b9a5201aa7d9ab0e42cdb/R/render.R#L125

May just need to check for a value before setting?

hadley commented 1 week ago

I don't have time to get this done today, I don't think it's that important, and we're likely to do a patch release in a few weeks, so I'm pushing this to the next release.