search

r-lib / pkgdown

Generate static html documentation for an R package
https://pkgdown.r-lib.org/
Other
721 stars 336 forks source link

Suppress warning from {desc} in test #2794

Closed maelle closed 1 month ago

github-actions[bot] commented 1 month ago

🚀 Deployed on https://67111c99e331c339442619ae--pkgdown-dev.netlify.app

hadley commented 1 month ago

Maybe suppressWarnings() since we don't care whether or not there's a warning, we just want to silence it?

maelle commented 1 month ago

Don't we want the test to fail when there's no warning in order to remove the comment that is just above it?

hadley commented 1 month ago

I don't think so because then if a new version of desc was released that removed the warning, then pkgdown would fail checks on CRAN. i.e. it creates an strong connection between the two packages for relatively little gain (i.e. at some point in the future someone will look at that code and be confused that there's no longer a warning).

maelle commented 1 month ago

Thank you for the explanation, I updated the file.