search

r-lib / progress

Progress bar in your R terminal
http://r-lib.github.io/progress/
Other
468 stars 39 forks source link

Fix dead README links to C++ API example package #117

Closed Lenostatos closed 3 years ago

Lenostatos commented 3 years ago

Fixes #100.

gaborcsardi commented 3 years ago

Thanks! I am afraid that if we want to make this work on CRAN as well (https://cran.rstudio.com/web/packages/progress/readme/README.html), then we'll have to use absolute links. Or omit the links completely.

Lenostatos commented 3 years ago

I understand. I didn't think of the CRAN version. Should I change the links to absolute links to GitHub? I don't know how to link to the files on CRAN and whether this is possible in the first place (e.g. I tried https://cran.rstudio.com/web/packages/progress/tests/testthat/progresstest/src/test.cpp but got a 404).

gaborcsardi commented 3 years ago

Yeah, I think an absolute link as https://github.com/r-lib/progress/blob/HEAD/tests/testthat/progresstest/src/test.cpp should be fine. Thanks!

Lenostatos commented 3 years ago

Alright, did ti!

Just out of curiosity: Why .../blob/HEAD/... instead of .../blob/master/...? Does it make a difference? I tried to google it but couldn't find anything conclusive on the matter.

gaborcsardi commented 3 years ago

Thanks! HEAD will link to the default branch, which is currently master, but we might change it later.

Lenostatos commented 3 years ago

I see. Thanks!