r-lib / ps

R package to query, list, manipulate system processes
https://ps.r-lib.org/
Other
77 stars 19 forks source link

Add `ps_disk_io_counters()` for Windows and Linux #147

Closed michaelwalshe closed 1 month ago

michaelwalshe commented 1 year ago

Implement ps_disk_io_counters for Linux and Windows based on psutil.

Adds new functions

Plus the following C function for windows:

Implementation of all functions heavily based on implementation from https://github.com/giampaolo/psutil/blob/master/psutil/_pslinux.py

User facing ps_disk_io_counters is tested, although not extensively as that requires mocking e.g. readLines which testthat currently cannot do.

Closes #145.

michaelwalshe commented 1 year ago

Hi @gaborcsardi, have just updated the NEWS.md so this should be ready for review/merge now, please let me know if there's anything I need to change or update.

gaborcsardi commented 1 month ago

Thank you and sorry for the long wait! I adjusted it a bit, most importantly I removed the perdisk parameter, and added a macOS implementation. Thanks again!