search

r-lib / ragg

Graphic Devices Based on AGG
https://ragg.r-lib.org
Other
172 stars 24 forks source link

use libjpeg-devel instead of libjpeg-turbo-devel in configure? #137

Closed kevinushey closed 11 months ago

kevinushey commented 1 year ago

E.g. on OpenSUSE Leap:

64129221c956:/ # zypper search libjpeg
S | Name            | Summary                                                               | Type
--+-----------------+-----------------------------------------------------------------------+--------
  | libjpeg-turbo   | A SIMD-accelerated library for manipulating JPEG image files          | package
  | libjpeg8        | A SIMD-accelerated JPEG compression/decompression library             | package
  | libjpeg8-devel  | Development Tools for applications which will use the Libjpeg Library | package
  | libjpeg62       | A SIMD-accelerated JPEG compression/decompression library             | package
  | libjpeg62-devel | Development Tools for applications which will use the Libjpeg Library | package
  | libjpegxr0      | Open source implementation of jpegxr

And libjpeg-devel will install the "right" package for you. But the configure script declares that it wants libjpeg-turbo-devel:

https://github.com/r-lib/ragg/blob/f6acc4c89540a71743074455d5c93e7f48ff075e/configure#L10

Should that just be libjpeg-devel? Note that this also gives you the right thing on Fedora:

[root@a65e219c06a1 /]# yum install libjpeg-devel
Last metadata expiration check: 0:01:56 ago on Wed Jul  5 00:06:24 2023.
Dependencies resolved.
====================================================================================================================================================================================================================
 Package                                                   Architecture                                  Version                                                Repository                                     Size
====================================================================================================================================================================================================================
Installing:
 libjpeg-turbo-devel                                       aarch64                                       2.1.4-2.fc38                                           fedora                                         98 k
Installing dependencies:
 cmake-filesystem                                          aarch64                                       3.26.4-4.fc38                                          updates                                        17 k
 libjpeg-turbo                                             aarch64                                       2.1.4-2.fc38                                           fedora                                        196 k
 libpkgconf                                                aarch64                                       1.8.0-6.fc38                                           fedora                                         36 k
 pkgconf                                                   aarch64                                       1.8.0-6.fc38                                           fedora                                         41 k
 pkgconf-m4                                                noarch                                        1.8.0-6.fc38                                           fedora                                         14 k
 pkgconf-pkg-config                                        aarch64                                       1.8.0-6.fc38                                           fedora                                        9.6 k

Transaction Summary
====================================================================================================================================================================================================================
Install  7 Packages

Total download size: 412 k
Installed size: 1.3 M
Is this ok [y/N]: