search

r-lib / rcmdcheck

Run R CMD check from R and collect the results
https://rcmdcheck.r-lib.org
Other
115 stars 27 forks source link

`get_test_fail()` failure on R devel #183

Open dhersz opened 2 years ago

dhersz commented 2 years ago

Hi. I just changed the checking CI on a package I'm writing and I stumbled upon what seems to be a rcmdcheck error.

You can see on line 101 of the action log here the error message:

 Error in dir(path, pattern = "^tests") : 
  translating strings with "bytes" encoding is not allowed
Calls: <Anonymous> ... get_test_fail -> get_test_output -> file.path -> dir

This seems to be the offending line of code, in get_test_output():

https://github.com/r-lib/rcmdcheck/blob/bda6e7121679a4df387b01bf28a7a050ec122805/R/parse.R#L85

I'm not really sure what is the source of error here, but I suspect it relates to recent regular expression changes that have been going on in R devel?

Happy to help with anything. Cheers.

gaborcsardi commented 2 years ago

Thanks! AFAICT that change was reverted, so everything should be fine soonish: https://github.com/wch/r-source/commit/ef0a4a211f92640e71e87cbe7b66323f2c239e4d

We can keep this issue open, we might as well work around this at the next release.