search

r-lib / remotes

Install R packages from GitHub, GitLab, Bitbucket, git, svn repositories, URLs
https://remotes.r-lib.org/
Other
336 stars 153 forks source link

Bioc-devel should use master branch, not 'HEAD' #611

Closed bbimber closed 3 years ago

bbimber commented 3 years ago

When the bioc development branch is specified, remotes will use 'HEAD' as the branch. This results in something like:


Downloading Bioconductor repo https://git.bioconductor.org/packages/SingleR
'/usr/bin/git' clone --depth 1 --no-hardlinks --branch HEAD https://git.bioconductor.org/packages/SingleR /tmp/Rtmpnl7qak/file945***70f4705f
Cloning into '/tmp/Rtmpnl7qak/file945***70f4705f'...
warning: Could not find remote branch HEAD to clone.

I think the problem, unless I'm missing some git behavior, is that HEAD isnt really a branch? Per here:

https://www.bioconductor.org/developers/how-to/git/

master serves as devel, so I think we want to target that.

bbimber commented 3 years ago

based on these test results I guess I'm supposed to update some test expectation files? happy to do this if you could give a little guidance.

bbimber commented 3 years ago

closing b/c i think #611 is a better option