search

r-lib / remotes

Install R packages from GitHub, GitLab, Bitbucket, git, svn repositories, URLs
https://remotes.r-lib.org/
Other
331 stars 152 forks source link

Update guidance on where to place GitHub PAT #689

Closed hfrick closed 2 years ago

hfrick commented 2 years ago

usethis now strongly discourages placing the PAT in .Renvir but a few functions in remotes still issue that guidance:

https://github.com/r-lib/remotes/blob/fcad17b68b7a19d5363d64adfb0a0426a3a5b3db/R/github.R#L183

https://github.com/r-lib/remotes/blob/fcad17b68b7a19d5363d64adfb0a0426a3a5b3db/inst/install-github.R#L2684

This could be replaced with "Use `gitcreds::gitcreds_set()` to add the token." or something similar? I'd make a PR but am unsure if this includes updating the corresponding line in ./install-github.R as well?

gaborcsardi commented 2 years ago

A PR is welcome. :) install-github.R is updated by running make.