r-lib / remotes

Install R packages from GitHub, GitLab, Bitbucket, git, svn repositories, URLs
https://remotes.r-lib.org/
Other
331 stars 152 forks source link

devtools::install_github forces upgrade of dependencies despite upgrade_dependencies=FALSE #693

Closed carbocation closed 2 years ago

carbocation commented 2 years ago

This is essentially a duplicate of issue r-lib/devtools#863. My specific issue is that I'm on a Mac with systemfonts v1.0.2, installing packages with devtools::install_github that depend on systemfonts. Even when I pass upgrade_dependencies=FALSE, the program tries to upgrade systemfonts to v1.0.3, which is not currently working (compiler issues for objective c).

If I install packages that depend on systemfonts via install.packages, there is no issue. But since devtools::install_github forces an upgrade of systemfonts to the latest version, even though I am trying to prevent it from doing so, I am unable to complete the installation of packages with devtools::install_github.

This is with R version 3.6.3 and devtools version 2.3.2 on x86_64-apple-darwin15.6.0 / macOS 10.16.

jennybc commented 2 years ago

devtools::install_github() is a very thin wrapper around remotes::install_github(), so I am transferring this issue to remotes.

I will note that I don't see this behaviour. Is there any chance this is a matter of you specifying upgrade_dependencies, whereas the relevant argument name is actually upgrade? Your devtools version is also pretty old FWIW.

gaborcsardi commented 2 years ago

What is the version of remotes that you have installed? Do you see this for the latest remotes version, with the name of the argument correctly specified as upgrade?

carbocation commented 2 years ago

Thanks! remotes had a version of remotes_2.2.0. I have now upgraded to remotes_2.4.2 and I no longer have this problem. (I cannot guarantee that the issue was present in remotes_2.2.0, I can just report that since upgrading I am no longer having the problem.)