r-lib / remotes

Install R packages from GitHub, GitLab, Bitbucket, git, svn repositories, URLs
https://remotes.r-lib.org/
Other
330 stars 152 forks source link

Allow explicit package names in Remotes #719

Closed heavywatal closed 2 years ago

heavywatal commented 2 years ago

This package somehow manages differences in repo names vs package names. Ignoring the leading "pkgname=" part is enough to let this package work.

Addresses #676

gaborcsardi commented 2 years ago

Great idea! I think we could make the implementation a bit safer by matching only something like ^[.a-zA-Z0-9]+= instead of just a plain = which might appear in some remote specifications.

heavywatal commented 2 years ago

Revised. Thank you for the suggestion.

gaborcsardi commented 2 years ago

Great, thanks! Can you please also add a bullet point to NEWS.md, mentioning this PR (or the issue) and your GH username?

heavywatal commented 2 years ago

Done.

gaborcsardi commented 2 years ago

Thank you!