r-lib / remotes

Install R packages from GitHub, GitLab, Bitbucket, git, svn repositories, URLs
https://remotes.r-lib.org/
Other
330 stars 152 forks source link

intstall_github gives: System command 'Rcmd.exe' failed #722

Closed JASlotman closed 1 year ago

JASlotman commented 1 year ago

Ive recently updated to R 4.2.1 and Rtools42 on windows 10. And I now get an Rcmd failure. Ive looked around to find solutions to this and set correct paths etc but the issue is still there.

Since we made the SMoLR package I'd like to know how to solve this problem because using devtools is our standard way of letting users install this package. Is there any solution to this issue?

> install_github("ErasmusOIC/SMoLR", build_vignettes = TRUE)
Downloading GitHub repo ErasmusOIC/SMoLR@HEAD
✔  checking for file 'C:\Users\769011\AppData\Local\Temp\RtmpOmhc3a\remotes500c20747da2\ErasmusOIC-SMoLR-fce6bd2/DESCRIPTION' ...
─  preparing 'SMoLR':
✔  checking DESCRIPTION meta-information ... 
   Warning: C:/Users/769011/AppData/Local/Temp/RtmpO6lD4H/Rbuild5e5821c95725/SMoLR/man/SMOLR_FAST_IMPORT.Rd:66: unexpected END_OF_INPUT '
   '
   Warning: C:/Users/769011/AppData/Local/Temp/RtmpO6lD4H/Rbuild5e5821c95725/SMoLR/man/SMOLR_PROFILE.Rd:71: unexpected END_OF_INPUT '
   '
─  installing the package to build vignettes
         -----------------------------------
─  installing *source* package 'SMoLR' ...
   ** using staged installation
   ** R
   ** data
   *** moving datasets to lazyload DB
   ** inst
   ** byte-compile and prepare package for lazy loading
   Error in loadNamespace(i, c(lib.loc, .libPaths()), versionCheck = vI[[i]]) : 
     there is no package called 'manipulateWidget'
   Calls: <Anonymous> ... loadNamespace -> withRestarts -> withOneRestart -> doWithOneRestart
   Execution halted
   ERROR: lazy loading failed for package 'SMoLR'
─  removing 'C:/Users/769011/AppData/Local/Temp/RtmpO6lD4H/Rinst5e5817453352/SMoLR'
         -----------------------------------
   ERROR: package installation failed
Error: Failed to install 'SMoLR' from GitHub:
  ! System command 'Rcmd.exe' failed
JASlotman commented 1 year ago

Oops Im very sorry, ive missed the manipulateWidget error. Somehow that dependency gives the issue. Dont know how I missed that for days. With a manipulateWidget present everything works fine.

gaborcsardi commented 1 year ago

You import that package from the NAMESPACE but don't require it in DESCRIPTION. Running R CMD check can detect these kind of issues.

JASlotman commented 1 year ago

Thanks a lot I'll change that!