search

r-lib / revdepcheck

R package reverse dependency checking
https://revdepcheck.r-lib.org
Other
101 stars 32 forks source link

ignore argument to revdep_check #211

Closed rhijmans closed 4 years ago

rhijmans commented 5 years ago

I needed an ignore="BIOMASS" argument when running revdep_check with package raster as it led to an error. (on windows; perhaps because of the vignette; given that CRAN does not check it). I imagine it will be useful to others as well.

rhijmans commented 5 years ago

The same error actually occurs with several packages. It is invariably:

Error in substring(sql, 0, pos$start[i] - 1) :  invalid multibyte string, element 1

And comes with these warning messages

In addition: Warning messages:
1: In grep("^[^\\s]+:$", lines, perl = TRUE, value = TRUE) :
  input string 7 is invalid UTF-8
2: In grep("^[^\\s]+:$", lines, perl = TRUE, value = TRUE) :
  input string 8 is invalid UTF-8
gaborcsardi commented 5 years ago

Thanks! We have now revdep_rm(), which removes packages from the queue. Maybe that is enough, as you probably only want to remove packages if they fail for some reason.

rhijmans commented 4 years ago

I find this too cumbersome. There are 14 packages that fail when revdepping raster ("BIOMASS","cartography","esmisc", "geozoning", "npphen", "prioritizr", "rpostgisLT", "RSIP", "rWind", "scBio", "solaR", "SpatialPosition", "tanaka", "eRTG3"). I would like to state at the beginning that these should be skipped.

However, it would seem much better if revdepcheck would not fail to begin with, and continues checking.

hadley commented 4 years ago

I think we'll now handle this as part of #69