Open lionel- opened 4 years ago
To check broken packages we currently need to be careful to add the failures to the set to test, otherwise they will disappear from the report (which is particularly problematic if these failures are caused by the dev version of the package):
pkgs <- cloud_broken(job, install_failures = TRUE, timeout_failures = TRUE) cloud_check(revdep_packages = pkgs)
It seems it would be safer and more practical to make cloud_broken() return failures by default, then it's just:
cloud_broken()
cloud_check(revdep_packages = cloud_broken(job))
Alternatively this could be wrapped in a cloud_recheck() function.
cloud_recheck()
cloud_recheck <- function(job_id = cloud_job()) { pkgs <- cloud_broken(job_id, install_failures = TRUE, timeout_failures = TRUE) cloud_check(revdep_packages = pkgs) }
cc @jimhester
To check broken packages we currently need to be careful to add the failures to the set to test, otherwise they will disappear from the report (which is particularly problematic if these failures are caused by the dev version of the package):
It seems it would be safer and more practical to make
cloud_broken()
return failures by default, then it's just:Alternatively this could be wrapped in a
cloud_recheck()
function.cc @jimhester