search

r-lib / revdepcheck

R package reverse dependency checking
https://revdepcheck.r-lib.org
Other
99 stars 31 forks source link

Re-enable checking of vignettes? #277

Open HenrikBengtsson opened 3 years ago

HenrikBengtsson commented 3 years ago

Hi, I just ran into a case where CRAN's incoming reverse-dependency checks caught a bug in my submitted package that revealed itself only in a vignette in one of the 138 reverse-depency packages.

After some troubleshooting, I figured out that revdepcheck:revdep_check() skips the vignettes for its checks;

https://github.com/r-lib/revdepcheck/blob/61ab33e6adc3cfcb5d51012b8ad7e94fd99a092c/R/check.R#L32

I don't see an obvious way to re-enable vignette checks. Could you please add this as an argument that can be overridden, e.g. args = c("--no-manual", "--no-build-vignettes")?

bbolker commented 1 year ago

Bump! I just got bitten by this ...

gaborcsardi commented 1 year ago

For the record, --no-build-vignettes still runs all the code in the vignettes, only does not build the output PDF or HTML. Nevertheless, I don't mind if we make this configurable with an env var.