search

r-lib / revdepcheck

R package reverse dependency checking
https://revdepcheck.r-lib.org
Other
99 stars 31 forks source link

cleaning up after revdep_check() #297

Open friendly opened 3 years ago

friendly commented 3 years ago

There are two issues here: (1) disconnecting from some database used in revedep_check() and (2) cleaning up the revdep/ folder.

(1) When I run revdep_check() on a package I get a message to disconnect from some database using dbDisconnect() What package? I tried DBI::dbDisconnect(), but that failed. Please make this message more explicit.

-- REPORT --------------------------------------------------------------------------------------------------------------------------
Writing summary to 'revdep/README.md'
Writing problems to 'revdep/problems.md'
Writing failures to 'revdep/failures.md'
Warning message:
call dbDisconnect() when finished working with a connection 
> dbDisconnect()
Error in dbDisconnect() : could not find function "dbDisconnect"
> DBI::dbDisconnect()
Error in (function (classes, fdef, mtable)  : 
  unable to find an inherited method for function ‘dbDisconnect’ for signature ‘"missing"’

(2) revdep_check() leaves all its' files in the revdep/ folder, but it is not clear what to do with them wrt git and github.

I was just burned by a revdep/ folder in the repo from a past release. Trying to run revdep_reset() kept failing, Could not delete data.sqlite.

mine-cetinkaya-rundel commented 3 years ago

I believe part of (2) is addressed if you first use usethis::use_revdep() as it puts the revdep directory in .Rbuildignore and also populated revdep/.gitignore to prevent tracking of various revdep artefacts.

I do think it might be helpful to mention usethis::use_revdep() in the recdepcheck README, almost as a first step before running any functions from this package.

friendly commented 3 years ago

thanks.
The warning message mentioned in (1) should also be addressed.

gaborcsardi commented 3 years ago

It is a harmless warning, you can ignore it.