search

r-lib / revdepcheck

R package reverse dependency checking
https://revdepcheck.r-lib.org
Other
99 stars 31 forks source link

Detect github API remotes #328

Open lionel- opened 2 years ago

lionel- commented 2 years ago

I just had a cloud check run where all packages failed because I forgot to change the remote to use URL form. When this happens, the cloud report does not contain any information about the failure. The new folders are completely missing from the results.

To avoid this, cloud_check() could detect non-url remotes in the description file and refuse to run if any is detected, with a suggestion to use url form instead. Or perhaps it could generate url remotes automatically before building the tarball?

DavisVaughan commented 1 year ago

I'd definitely be in favor of at least erroring. This has happened to me many times, most recently with tidyr's 1700ish revdeps

Just for our reference, the correct URL I needed to use was

Remotes:
    url::https://github.com/tidyverse/stringr/archive/main.tar.gz

I think in the error message we could probably tell users what we think the url should look like, but it might not work in all cases (like if they haven't switched from master to main) so idk if we should automatically apply it