search

r-lib / revdepcheck

R package reverse dependency checking
https://revdepcheck.r-lib.org
Other
99 stars 31 forks source link

Add cran parameter (#333 and #340 candidate fix) #334

Closed maksymiuks closed 1 month ago

maksymiuks commented 2 years ago

@gaborcsardi This is a candidate fix for #333

I've realized that fixing the issue reported above is dead simple. In my opinion get_repos() helper should append CRAN to repos only conditionally on some input parameter, rather than every time CRAN is not found in current options. Therefore I've just added this parameter and propagated it upstream including revdep_check() and documentation.

maksymiuks commented 2 years ago

Requesting review @gaborcsardi

maksymiuks commented 1 year ago

@gaborcsardi Is there any chance to address this in the nearest future?

maksymiuks commented 1 year ago

Added candidate fix for #340

gaborcsardi commented 1 month ago

Thanks and sorry for the super long wait!