r-lib / revdepcheck

R package reverse dependency checking
https://revdepcheck.r-lib.org
Other
99 stars 31 forks source link

difficulties with revdep_rm #335

Open bbolker opened 1 year ago

bbolker commented 1 year ago

My use case is that I want to use revdep_check to check a single reverse dependency, having not done a full check run previously. I thought I could do this as follows (1) find all packages to be checked; (2) use revdep_rm to remove them all; (3) use revdep_add to add back just the one I want to check. (Alternately, could use setdiff() in step 2 to remove all but the package to be checked ...)

library(revdepcheck)
pkg <- "gtools"
to_check <- "dnapath"
pkgs_todo <- revdep_todo(pkg)$package
str(pkgs_todo)
##  chr [1:291] "AgiMicroRna" "AgroR" "AlphaBeta" "ANTs" "ArchaeoPhases" ...
revdep_rm(pkg, pkgs_todo)
pkgs_todo <- revdep_todo(pkg)$package
str(pkgs_todo)
## same as before ???

But revdep_rm doesn't appear to have any effect on the results of revdep_todo, whether I try to remove all packages or just a single package.

Am I having a thinko here ...?

sessionInfo()
R Under development (unstable) (2022-07-07 r82558)
Platform: x86_64-pc-linux-gnu (64-bit)
Running under: Pop!_OS 22.04 LTS

[matrix products, locale snipped]

attached base packages:
[1] stats     graphics  grDevices utils     datasets  methods   base     

other attached packages:
[1] revdepcheck_1.0.0.9001

loaded via a namespace (and not attached):
 [1] rappdirs_0.3.3       utf8_1.2.2           RSQLite_2.2.14      
 [4] hms_1.1.1            digest_0.6.29        magrittr_2.0.3      
 [7] fastmap_1.1.0        blob_1.2.3           jsonlite_1.8.0      
[10] rprojroot_2.0.3      processx_3.7.0       parsedate_1.3.0     
[13] progress_1.2.2       sessioninfo_1.2.2    pkgbuild_1.3.1      
[16] whoami_1.3.0         DBI_1.1.3            rcmdcheck_1.4.0     
[19] rematch2_2.1.2       ps_1.7.1             httr_1.4.3          
[22] fansi_1.0.3          cli_3.3.0.9000       rlang_1.0.3         
[25] crayon_1.5.1         cranlike_1.0.2       ellipsis_0.3.2      
[28] bit64_4.0.5          yaml_2.3.5           remotes_2.4.2       
[31] withr_2.5.0          base64enc_0.1-3      cachem_1.0.6        
[34] crancache_0.0.0.9001 tools_4.3.0          gargle_1.2.0        
[37] debugme_1.1.0        memoise_2.0.1        gmailr_1.0.1        
[40] curl_4.3.2           assertthat_0.2.1     vctrs_0.4.1         
[43] R6_2.5.1             lifecycle_1.0.1      fs_1.5.2            
[46] bit_4.0.4            xopen_1.0.0          clisymbols_1.2.0    
[49] pkgconfig_2.0.3      desc_1.4.1           callr_3.7.0         
[52] pillar_1.7.0         glue_1.6.2           Rcpp_1.0.8.3        
[55] xfun_0.31            tibble_3.1.7         knitr_1.39          
[58] compiler_4.3.0       prettyunits_1.1.1   
gaborcsardi commented 1 year ago

Look at the second column:

❯ revdepcheck:::revdep_todo()
             package status
1             acumos ignore
2           AMARETTO ignore
3           basilisk ignore
4                cli ignore
5             cliapp ignore
6          clustermq ignore

ignore means that it will indeed be ignored.