r-lib / revdepcheck

R package reverse dependency checking
https://revdepcheck.r-lib.org
Other
101 stars 32 forks source link

Installation failure is not reported #350

Open be-marc opened 1 year ago

be-marc commented 1 year ago

I checked the package mlr3tuning and the installation of the reverse dependency mlr3verse failed in new and old. This is recorded in the 00check.log files:

* using log directory ‘/home/ubuntu/mlr3tuning/revdep/checks/mlr3verse/new/mlr3verse.Rcheck’
* using R version 4.2.2 (2022-10-31)
* using platform: x86_64-pc-linux-gnu (64-bit)
* using session charset: UTF-8
* using options ‘--no-manual --no-build-vignettes’
* checking for file ‘mlr3verse/DESCRIPTION’ ... OK
* this is package ‘mlr3verse’ version ‘0.2.6’
* package encoding: UTF-8
* checking package namespace information ... OK
* checking package dependencies ... ERROR
Packages required but not available: 'mlr3hyperband', 'mlr3tuningspaces'

See section ‘The DESCRIPTION file’ in the ‘Writing R Extensions’
manual.
* DONE
Status: 1 ERROR

But this is not recorded in failures.md, problems.md, readme.md and cran.md. I only could see this in the print of revdepcheck::revdep_check(). I don't know why the installation failed but this should still be recorded, right?

xrobin commented 1 year ago

This is an interesting development of #209.

I must say I got hit by it today - I should have suspected that all checks being OK was weird.

Summary reports everything as OK...

> revdepcheck::revdep_summary()
✔ aplore3 0.9                            ── E: 0     | W: 0     | N: 0    
✔ arsenal 3.6.3                          ── E: 0     | W: 0     | N: 0    
✔ AutoScore 1.0.0                        ── E: 0     | W: 0     | N: 0    
✔ bbl 1.0.0                              ── E: 0     | W: 0     | N: 0    
✔ BDgraph 2.72                           ── E: 0     | W: 0     | N: 0    
✔ Biocomb 0.4                            ── E: 0     | W: 0     | N: 0    
✔ BioPET 0.2.2                           ── E: 0     | W: 0     | N: 0    

However this is clearly not the case, with dependencies that weren't installed:

> revdepcheck::revdep_details(pkg=".", "AutoScore")
══ Reverse dependency check ═════════════════════════════════════════════════════════════════════════════════════ AutoScore 1.0.0 ══

Status: OK

── Before ──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
❯ checking package dependencies ... ERROR
  Packages required but not available:
    'tableone', 'car', 'coxed', 'ordinal', 'tidyr', 'randomForestSRC',
    'survAUC', 'survminer'

  See section ‘The DESCRIPTION file’ in the ‘Writing R Extensions’
  manual.

1 error ✖ | 0 warnings ✔ | 0 notes ✔

── After ───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
❯ checking package dependencies ... ERROR
  Packages required but not available:
    'tableone', 'car', 'coxed', 'ordinal', 'tidyr', 'randomForestSRC',
    'survAUC', 'survminer'

  See section ‘The DESCRIPTION file’ in the ‘Writing R Extensions’
  manual.

1 error ✖ | 0 warnings ✔ | 0 notes ✔

This is with a revdepcheck installed a few minutes ago.

MLopez-Ibanez commented 6 months ago

Same as #343 ?

MLopez-Ibanez commented 6 months ago

Same as #219

MLopez-Ibanez commented 6 months ago

Same as #256