r-lib / rlang

Low-level API for programming with R
https://rlang.r-lib.org
Other
508 stars 138 forks source link

Reimplement `zap_srcref()` in C #1513

Closed hadley closed 1 year ago

hadley commented 2 years ago

It's causing a bottleneck in large shiny apps.

hadley commented 1 year ago

Would be great to prioritise this in the next minor release.

wch commented 1 year ago

Just to add some data, here's a profvis flame graph showing how much time is spent in zap_srcref when a user connects to a large Shiny app. In this app, it's 640ms, and each user has to pay this price.

image (18)