search

r-lib / rlang

Low-level API for programming with R
https://rlang.r-lib.org
Other
498 stars 136 forks source link

Pass `allow_na = FALSE` #1592

Closed mgirlich closed 1 year ago

mgirlich commented 1 year ago

I stumbled this when working on #1590. As they don't accept NA it makes sense to explicitly pass allow_na = FALSE so that you cannot pass it accidentally via the ... arguments (this happened in the tests). I thought this isn't worth a NEWS entry but if you want I can add one.

lionel- commented 1 year ago

Thanks! Can you bump the last-updated field please? Or maybe I'll do it after release after merging, since there are multiple changes coming up.

lionel- commented 1 year ago

It's best not to touch the versions by the way, to prevent conflicts. For instance I'm now merging into 1.0.6.9000 instead of 1.1.0.9000 as the release didn't go through.