r-lib / rlang

Low-level API for programming with R
https://rlang.r-lib.org
Other
489 stars 131 forks source link

Add `r_dyn_raw_push_back()` and `r_dyn_chr_push_back()` #1699

Closed DavisVaughan closed 3 months ago

DavisVaughan commented 3 months ago

Added 2 missing push-back helpers.

In https://github.com/r-lib/rlang/pull/1542 I optimized the push-back API by separating it from the generic r_dyn_push_back() helper. This was nice, but it left the typed push back API untested. In addition to adding those 2 missing helpers, this PR also adds the missing tests for the typed API.

DavisVaughan commented 3 months ago

Test failures seem unrelated but definitely worth taking a look at, as it seems important?