r-lib / rprojroot

Finding files in project subdirectories

https://rprojroot.r-lib.org/

Other

149 stars 23 forks source link

feat!: The `subdir` argument to `root_criterion()` must have length one #102

Closed krlmlr closed 9 months ago

krlmlr commented 9 months ago

Closes #84.

aviator-app[bot] commented 9 months ago

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes. Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was closed without merging. If you still want to merge this PR, re-open it.

See the real-time status of this PR on the Aviator webapp.

Use the Aviator Chrome Extension to see the status of your PR within GitHub.

aviator-app[bot] commented 9 months ago

This pull request failed to merge: this PR is in draft state. Remove the blocked label to re-queue.

Additional debug info: PR was marked as draft after queueing

krlmlr commented 9 months ago

@salim-b: Testing the implications of disallowing subdir with length > 1.

aviator-app[bot] commented 9 months ago

This pull request can't be queued because it's currently a draft.

krlmlr commented 9 months ago

Not needed.

salim-b commented 9 months ago

Not needed.

Just out of curiosity: What's your conclusion from this PR? What do you mean exactly by "not needed"?

krlmlr commented 9 months ago

More than that: it's a regression and harmful, the current behavior is necessary for is_testthat to work with R CMD check .

salim-b commented 9 months ago

Ok, thanks for clarifying ☺️