Closed BarkleyBG closed 6 years ago
Merging #33 into master will decrease coverage by
0.82%
. The diff coverage is50%
.
@@ Coverage Diff @@
## master #33 +/- ##
==========================================
- Coverage 86.97% 86.15% -0.83%
==========================================
Files 6 6
Lines 192 195 +3
==========================================
+ Hits 167 168 +1
- Misses 25 27 +2
Impacted Files | Coverage Δ | |
---|---|---|
R/rrmake.R | 88.88% <0%> (-11.12%) |
:arrow_down: |
R/criterion.R | 97.95% <66.66%> (-2.05%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 851d293...2ed7425. Read the comment docs.
Thanks. I think test-make.R
would be a good place to add a test. The tests there could use a bit of refactoring and perhaps comments, too. It's confusing because the make_...()
functions return a function which then needs to be called.
Thanks!
Fixes #32
How it works
Fails tests
So, either:
subdir=NULL
the default formake_fix_root_file()
What next
I'm not sure whether to change the default behavior or not, so I'll wait for response from @krlmlr