r-lib / rprojroot

Finding files in project subdirectories
https://rprojroot.r-lib.org/
Other
149 stars 23 forks source link

feat: Add `is_renv_project` criterion looking for an `renv.lock` file #86

Closed gadenbuie closed 10 months ago

gadenbuie commented 2 years ago

A small PR to add an is_renv_project criterion that finds an renv.lock file containing "Packages": {. I needed this in a project and thought it might be broadly useful to others.

I updated documentation but not the snapshot tests as I'm running into odd testthat and pkgload errors that are likely specific to my machine and that I don't have time to diagnose at the moment. Hopefully it'll be easy for you to update the snapshots.

aviator-app[bot] commented 10 months ago

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes. Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was merged using Aviator.


See the real-time status of this PR on the Aviator webapp.

Use the Aviator Chrome Extension to see the status of your PR within GitHub.
aviator-app[bot] commented 10 months ago

This pull request failed to merge: PR cannot be automatically rebased, please rebase manually to continue. Remove the blocked label to re-queue.

Additional debug info: Failed to rebase this PR onto the latest changes from the base branch. You will probably need to rebase this PR manually and resolve conflicts).

krlmlr commented 10 months ago

Yeah, updating the snapshot is tricky -- requires installing the package and running testthat::test_local(load_package = "none") . I can handle that.

aviator-app[bot] commented 10 months ago

This pull request failed to merge: PR cannot be automatically rebased, please rebase manually to continue. Remove the blocked label to re-queue.

Additional debug info: Failed to rebase this PR onto the latest changes from the base branch. You will probably need to rebase this PR manually and resolve conflicts).

aviator-app[bot] commented 10 months ago

This pull request failed to merge: some CI status(es) failed. Remove the blocked label to re-queue.

Failed CI(s): Smoke test: stock R

krlmlr commented 10 months ago

Thanks for the PR!