r-lib / rprojroot

Finding files in project subdirectories

https://rprojroot.r-lib.org/

Other

149 stars 23 forks source link

Add specific folders for testing in i386 and x64 #88

Closed llrs closed 8 months ago

llrs commented 2 years ago

I think this should cover #87.

I haven't added tests because I don't have access to a Windows machine (and I'm not sure if this is the right approach). I also haven't added a section in the NEWS, as I asked on #87, I'm not sure if it is worth it.

llrs commented 2 years ago

Sorry, it seems I cannot accept or review the snapshot changes from Rstudio, neither from the build panel or from the interactive terminal... I don't know how to fix the snapshots

aviator-app[bot] commented 8 months ago

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes. Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was closed without merging. If you still want to merge this PR, re-open it.

See the real-time status of this PR on the Aviator webapp.

Use the Aviator Chrome Extension to see the status of your PR within GitHub.

krlmlr commented 8 months ago

Is this still relevant, given that i386 is no longer present in recent R builds?

llrs commented 8 months ago

It might no longer be relevant: I wrote the patch more than a year ago and there haven't been more reports of this issue, so this and the issue can be closed.