r-lib / rprojroot

Finding files in project subdirectories
https://rprojroot.r-lib.org/
Other
149 stars 23 forks source link

feat: Add `is_quarto_project` criterion #92

Closed olivroy closed 11 months ago

olivroy commented 1 year ago

Fix #91 This PR also fixes some warnings with mockr.

Note that I was not able to load with load_all() on Windows

<error/rlang_error>
Error in `pkgload::load_all()`:
! Namespace for rprojroot can't already exist.
---
Backtrace:
    ▆
 1. └─pkgload::load_all()
 2.   └─pkgload:::create_ns_env(path)
 3.     └─cli::cli_abort(...)
 4.       └─rlang::abort(...)

Edit: I also forgot to create this PR from a branch..

Reference: https://quarto.org/docs/projects/quarto-projects.html

krlmlr commented 1 year ago

My last action probably messed up your local clone, fix with git fetch && git rebase .

olivroy commented 1 year ago

It is fine. Does the implementation look ok to you?

krlmlr commented 1 year ago

Thanks, looks good! I'll merge the next time I work on this package.

aviator-app[bot] commented 11 months ago

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes. Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was merged using Aviator.


See the real-time status of this PR on the Aviator webapp.

Use the Aviator Chrome Extension to see the status of your PR within GitHub.
aviator-app[bot] commented 11 months ago

This pull request failed to merge: PR cannot be automatically rebased, please rebase manually to continue. Remove the blocked label to re-queue.

Additional debug info: Failed to rebase this PR onto the latest changes from the base branch. You will probably need to rebase this PR manually and resolve conflicts).