Use `expect_snapshot(error = TRUE)` over `expect_error()`

r-lib / slider

Sliding Window Functions

https://slider.r-lib.org

Other

295 stars 12 forks source link

Use `expect_snapshot(error = TRUE)` over `expect_error()` #167

Closed DavisVaughan closed 2 years ago

DavisVaughan commented 2 years ago

Anywhere we "expected" a fixed string, since this is more robust and also lets us see the error call. Ideally we'd also snapshot the expect_error() tests we have that test against a class, but there are just too many of those to be useful.