Bump minimum needed R version to `3.6`

r-lib / styler

Non-invasive pretty printing of R code

https://styler.r-lib.org

Other

725 stars 71 forks source link

Bump minimum needed R version to `3.6` #1101

Closed IndrajeetPatil closed 1 year ago

IndrajeetPatil commented 1 year ago

R 4.3 is scheduled for release on April 21.

Follow-up on https://github.com/r-lib/styler/pull/985/

github-actions[bot] commented 1 year ago

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 57bbf4e54af3f9aedbcb5f0e2353ae1b19d1b30c is merged into main:

:exclamation::snail:cache_applying: 76ms -> 80ms [+3.5%, +7.09%]
:ballot_box_with_check:cache_recording: 1.04s -> 1.03s [-1.41%, +1.01%]
:ballot_box_with_check:without_cache: 2.5s -> 2.5s [-0.72%, +0.78%]

Further explanation regarding interpretation and methodology can be found in the documentation.

codecov-commenter commented 1 year ago

Codecov Report

Merging #1101 (5001fb9) into main (15a5f5b) will increase coverage by 1.08%. The diff coverage is 80.00%.

:exclamation: Current head 5001fb9 differs from pull request most recent head 6045bee. Consider uploading reports for the commit 6045bee to get more accurate results

@@            Coverage Diff             @@
##             main    #1101      +/-   ##
==========================================
+ Coverage   91.07%   92.16%   +1.08%     
==========================================
  Files          46       46              
  Lines        2701     2654      -47     
==========================================
- Hits         2460     2446      -14     
+ Misses        241      208      -33

Impacted Files	Coverage Δ
R/environments.R	`0.00% <0.00%> (-100.00%)`	:arrow_down:
R/parse.R	`87.65% <ø> (-0.16%)`	:arrow_down:
R/style-guides.R	`100.00% <ø> (+0.56%)`	:arrow_up:
R/nest.R	`100.00% <100.00%> (ø)`
R/relevel.R	`96.87% <100.00%> (+47.57%)`	:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

IndrajeetPatil commented 1 year ago

Newfound lint is a false positive: https://github.com/r-lib/lintr/issues/1963

github-actions[bot] commented 1 year ago

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 940010d41129746d44e52d44664a37e44559bd39 is merged into main:

:ballot_box_with_check:cache_applying: 256ms -> 259ms [-1.43%, +3.79%]
:ballot_box_with_check:cache_recording: 1.09s -> 1.09s [-1.64%, +0.81%]
:ballot_box_with_check:without_cache: 2.25s -> 2.23s [-1.85%, +0.84%]

Further explanation regarding interpretation and methodology can be found in the documentation.

github-actions[bot] commented 1 year ago

This is how benchmark results would change (along with a 95% confidence interval in relative change) if e5ecef721dd414873566526ab9ae432ecb3de4d5 is merged into main:

:ballot_box_with_check:cache_applying: 277ms -> 276ms [-3.38%, +2.9%]
:ballot_box_with_check:cache_recording: 1.3s -> 1.31s [-0.36%, +2.65%]
:ballot_box_with_check:without_cache: 2.74s -> 2.73s [-1.69%, +0.75%]

Further explanation regarding interpretation and methodology can be found in the documentation.

github-actions[bot] commented 1 year ago

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 15a5f5b8812aa1aa4b13de707627058020561860 is merged into main:

:ballot_box_with_check:cache_applying: 245ms -> 247ms [-1.53%, +3.2%]
:ballot_box_with_check:cache_recording: 746ms -> 744ms [-1.69%, +1.07%]
:ballot_box_with_check:without_cache: 1.37s -> 1.38s [-1.18%, +1.71%]

Further explanation regarding interpretation and methodology can be found in the documentation.