Use cli messaging for cache

r-lib / styler

Non-invasive pretty printing of R code

https://styler.r-lib.org

Other

713 stars 70 forks source link

Use cli messaging for cache #1127

Closed olivroy closed 1 year ago

olivroy commented 1 year ago

Add a link for RStudio users

github-actions[bot] commented 1 year ago

This is how benchmark results would change (along with a 95% confidence interval in relative change) if e8836fdf5c127848f943396def0dbc2994ed71d5 is merged into main:

:ballot_box_with_check:cache_applying: 237ms -> 237ms [-1.86%, +2.06%]
:ballot_box_with_check:cache_recording: 806ms -> 813ms [-0.17%, +1.87%]
:ballot_box_with_check:without_cache: 1.54s -> 1.54s [-0.52%, +0.61%]

Further explanation regarding interpretation and methodology can be found in the documentation.

lorenzwalthert commented 1 year ago

Looks good, thanks. If you want, you could add links to a few more places:

full text search for help(
full text search for `?

Also, if you search for https://github.com/, you find a few more places where we can use the .internal option for error and warnings.

olivroy commented 1 year ago

I fixed a test. However, I didn't find more places where .internal = TRUE would make sense. The only place was at https://github.com/r-lib/styler/blob/e8836fdf5c127848f943396def0dbc2994ed71d5/R/set-assert-args.R#L36,

but it wouldn't really fit in the context.

codecov-commenter commented 1 year ago

Codecov Report

Merging #1127 (4356de7) into main (e8836fd) will not change coverage. The diff coverage is 66.66%.

:exclamation: Current head 4356de7 differs from pull request most recent head 015874f. Consider uploading reports for the commit 015874f to get more accurate results

@@           Coverage Diff           @@
##             main    #1127   +/-   ##
=======================================
  Coverage   92.18%   92.18%           
=======================================
  Files          46       46           
  Lines        2650     2650           
=======================================
  Hits         2443     2443           
  Misses        207      207

Impacted Files	Coverage Δ
R/vertical.R	`60.00% <0.00%> (ø)`
R/set-assert-args.R	`90.47% <80.00%> (ø)`
R/stylerignore.R	`100.00% <100.00%> (ø)`

github-actions[bot] commented 1 year ago

This is how benchmark results would change (along with a 95% confidence interval in relative change) if e8836fdf5c127848f943396def0dbc2994ed71d5 is merged into main:

:ballot_box_with_check:cache_applying: 264ms -> 264ms [-1.1%, +1.08%]
:ballot_box_with_check:cache_recording: 869ms -> 869ms [-0.41%, +0.55%]
:ballot_box_with_check:without_cache: 1.62s -> 1.62s [-0.46%, +0.33%]

Further explanation regarding interpretation and methodology can be found in the documentation.