Fix double indention for function declaration if they have a base indention

r-lib / styler

Non-invasive pretty printing of R code

https://styler.r-lib.org

Other

725 stars 71 forks source link

Fix double indention for function declaration if they have a base indention #1137

Open lorenzwalthert opened 1 year ago

lorenzwalthert commented 1 year ago

Closes #1136.

lorenzwalthert commented 1 year ago

@MichaelChirico ~can you review the PR and in particular think about more cases for tests that I might not have considered?~ Actually I first have to fix things...

github-actions[bot] commented 1 year ago

This is how benchmark results would change (along with a 95% confidence interval in relative change) if acd0b469a88646318e9441a84d3ea29c51856f3a is merged into main:

:ballot_box_with_check:cache_applying: 231ms -> 230ms [-1.61%, +0.86%]
:ballot_box_with_check:cache_recording: 760ms -> 757ms [-1.31%, +0.53%]
:ballot_box_with_check:without_cache: 1.42s -> 1.42s [-0.52%, +0.3%]

Further explanation regarding interpretation and methodology can be found in the documentation.

MichaelChirico commented 1 year ago

@lorenzwalthert please ping again when it's ready, thanks!

github-actions[bot] commented 10 months ago

This is how benchmark results would change (along with a 95% confidence interval in relative change) if d6fee24545a76b621eca8a35b8293aba083bf156 is merged into main:

:ballot_box_with_check:cache_applying: 172ms -> 172ms [-1.26%, +1.14%]
:ballot_box_with_check:cache_recording: 544ms -> 546ms [-0.21%, +1.03%]
:exclamation::snail:without_cache: 1.02s -> 1.03s [+0.06%, +0.92%]

Further explanation regarding interpretation and methodology can be found in the documentation.

IndrajeetPatil commented 5 months ago

Rebasing because the logs from the last workflow runs have expired.

github-actions[bot] commented 5 months ago

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 99afa8df27ab65c011bb89ff5437ad32c31bd093 is merged into main:

:heavy_check_mark:cache_applying: 149ms -> 147ms [-5.12%, +1.42%]
:heavy_check_mark:cache_recording: 501ms -> 502ms [-0.69%, +1.04%]
:heavy_check_mark:without_cache: 975ms -> 975ms [-1.33%, +1.37%]

Further explanation regarding interpretation and methodology can be found in the documentation.

lorenzwalthert commented 5 months ago

thanks. My attempt was not working as expected and I don't have the bandwith to work on this at the moment.

github-actions[bot] commented 4 months ago

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 8b2b78881cd39a6b34d6b213ed917df1cf795219 is merged into main:

:rocket:cache_applying: 152ms -> 148ms [-5.73%, -0.6%]
:heavy_check_mark:cache_recording: 513ms -> 513ms [-0.93%, +0.8%]
:heavy_check_mark:without_cache: 981ms -> 982ms [-0.67%, +0.85%]

Further explanation regarding interpretation and methodology can be found in the documentation.