Follow up: Standalone should not be styled #1135

r-lib / styler

Non-invasive pretty printing of R code

https://styler.r-lib.org

Other

713 stars 70 forks source link

Follow up: Standalone should not be styled #1135 #1138

Closed lorenzwalthert closed 11 months ago

lorenzwalthert commented 1 year ago

Closes #1134. Superceeds #1135.

github-actions[bot] commented 1 year ago

This is how benchmark results would change (along with a 95% confidence interval in relative change) if acd0b469a88646318e9441a84d3ea29c51856f3a is merged into main:

:ballot_box_with_check:cache_applying: 223ms -> 225ms [-1.58%, +2.91%]
:ballot_box_with_check:cache_recording: 737ms -> 741ms [-0.14%, +1.28%]
:ballot_box_with_check:without_cache: 1.39s -> 1.39s [-0.32%, +0.93%]

Further explanation regarding interpretation and methodology can be found in the documentation.

lorenzwalthert commented 1 year ago

@IndrajeetPatil only if you have time, no worries otherwise.

codecov-commenter commented 11 months ago

Codecov Report

Merging #1138 (ea1996b) into main (957d64f) will increase coverage by 0.01%. The diff coverage is 100.00%.

:exclamation: Current head ea1996b differs from pull request most recent head 30e8f15. Consider uploading reports for the commit 30e8f15 to get more accurate results

@@            Coverage Diff             @@
##             main    #1138      +/-   ##
==========================================
+ Coverage   92.33%   92.35%   +0.01%     
==========================================
  Files          46       46              
  Lines        2650     2654       +4     
==========================================
+ Hits         2447     2451       +4     
  Misses        203      203

Files Changed	Coverage Δ
R/ui-styling.R	`100.00% <100.00%> (ø)`

lorenzwalthert commented 11 months ago

Thanks @IndrajeetPatil.

github-actions[bot] commented 11 months ago

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 957d64fb1e85af4283d5055d9159427bca7cf678 is merged into main:

:ballot_box_with_check:cache_applying: 282ms -> 284ms [-0.22%, +1.74%]
:ballot_box_with_check:cache_recording: 838ms -> 841ms [-0.37%, +1.02%]
:ballot_box_with_check:without_cache: 1.52s -> 1.52s [-0.84%, +0.27%]

Further explanation regarding interpretation and methodology can be found in the documentation.