r-lib / styler

Non-invasive pretty printing of R code
https://styler.r-lib.org
Other
725 stars 71 forks source link

Fix CRAN warning on invalid numeric version inputs #1143

Closed lorenzwalthert closed 1 year ago

lorenzwalthert commented 1 year ago

This is about the "invalid non-character version specification" errors for r-devel-linux-x86_64-debian-gcc. R-devel has been warning about invalid (non-character) numeric version inputs for some time now, but such warnings typically go unnoticed, so at least for the time being, one can get errors instead of warnings by setting _R_CHECK_STOP_ON_INVALID_NUMERIC_VERSIONINPUTS=true. In your case, assert_transformers <- function(transformers) { version_cutoff <- 2.0 needs "2.0" ...

codecov-commenter commented 1 year ago

Codecov Report

Merging #1143 (17167fd) into main (1fc5b13) will not change coverage. The diff coverage is 100.00%.

:exclamation: Current head 17167fd differs from pull request most recent head 922573c. Consider uploading reports for the commit 922573c to get more accurate results

@@           Coverage Diff           @@
##             main    #1143   +/-   ##
=======================================
  Coverage   92.33%   92.33%           
=======================================
  Files          46       46           
  Lines        2650     2650           
=======================================
  Hits         2447     2447           
  Misses        203      203           
Files Changed Coverage Δ
R/set-assert-args.R 90.47% <100.00%> (ø)
github-actions[bot] commented 1 year ago

This is how benchmark results would change (along with a 95% confidence interval in relative change) if aca72239b6e4715b0648d2429695229e8c1a7a64 is merged into main:

Further explanation regarding interpretation and methodology can be found in the documentation.

github-actions[bot] commented 1 year ago

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 1fc5b1386a70ae92628131d9677d8308d6a6e8e1 is merged into main:

Further explanation regarding interpretation and methodology can be found in the documentation.

github-actions[bot] commented 1 year ago

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 1fc5b1386a70ae92628131d9677d8308d6a6e8e1 is merged into main:

Further explanation regarding interpretation and methodology can be found in the documentation.

lorenzwalthert commented 1 year ago

on win devel, the message is not even shown:

Insufficient package version (submitted: 1.10.1, existing: 1.10.1)

Documented arguments not in \usage in documentation object 'set_line_break_if_call_is_multi_line': 'except_token_after' 'except_text_before' 'force_text_before'

Functions with \usage entries need to have the appropriate \alias entries, and all their arguments documented. The \usage entries must correspond to syntactically valid R code. See chapter 'Writing R documentation files' in the 'Writing R Extensions' manual.

lorenzwalthert commented 1 year ago

Quite strange that the GitHub Action itself fails at 0s. Opened an issue: https://github.com/r-lib/actions/issues/756

github-actions[bot] commented 1 year ago

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 1fc5b1386a70ae92628131d9677d8308d6a6e8e1 is merged into main:

Further explanation regarding interpretation and methodology can be found in the documentation.

github-actions[bot] commented 1 year ago

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 1fc5b1386a70ae92628131d9677d8308d6a6e8e1 is merged into main:

Further explanation regarding interpretation and methodology can be found in the documentation.

github-actions[bot] commented 1 year ago

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 1fc5b1386a70ae92628131d9677d8308d6a6e8e1 is merged into main:

Further explanation regarding interpretation and methodology can be found in the documentation.