search

r-lib / styler

Non-invasive pretty printing of R code
https://styler.r-lib.org
Other
713 stars 70 forks source link

Delete URL check workflow #1160

Closed IndrajeetPatil closed 9 months ago

IndrajeetPatil commented 9 months ago

I am not sure what's special about {styler} that this workflow fails. My hunch is that including a lot of GitHub links corresponding to all contributors somehow makes GitHub API calls exceed beyond the limit for this workflow in this repo.

At any rate, this is not so important to merit further investigation. We just need to run URL check before CRAN submission and we should be fine.

IndrajeetPatil commented 9 months ago

The precommit workflow is going to fail until https://github.com/r-lib/styler/pull/1158 is merged, and so need to wait for that PR to be merged.

codecov-commenter commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (12f7eb6) 92.35% compared to head (5b8e8f0) 92.35%. Report is 5 commits behind head on main.

:exclamation: Current head 5b8e8f0 differs from pull request most recent head ae7b351. Consider uploading reports for the commit ae7b351 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1160 +/- ## ======================================= Coverage 92.35% 92.35% ======================================= Files 46 46 Lines 2654 2654 ======================================= Hits 2451 2451 Misses 203 203 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

lorenzwalthert commented 9 months ago

Ok. So actually I remember now that this issue came up before: https://stackoverflow.com/questions/66738272/how-to-fix-r-cmd-check-note-on-incoming-feasibility-due-to-too-many-requests-f

lorenzwalthert commented 9 months ago

But I am fine deleting the workflow and do the check upon submission.