Closed IndrajeetPatil closed 9 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
10efce2
) 92.16% compared to head (4447865
) 92.16%.:exclamation: Current head 4447865 differs from pull request most recent head aac55d7. Consider uploading reports for the commit aac55d7 to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@lorenzwalthert Can we deal with this flaky test? It is making it more likely that we miss out an actual failing test.
══ Failed tests ════════════════════════════════════════════════════════════════
── Failure ('tests-cache-require-serial.R:28:3'): top-level test: Caches top-level expressions efficiently on style_text() ──
full_cached_benchmark["elapsed"] * 30 is not strictly less than benchmark["elapsed"]. Difference: 0.01
Yeah let's lift the hurdle for failing, e.g. x20 instead of x 30?
Sounds good, thanks for implementing. If you want, you can also add the fix for the offending unrelated test to this PR.
Closes #1161