r-lib / styler

Non-invasive pretty printing of R code
https://styler.r-lib.org
Other
703 stars 70 forks source link

Improve error message for scope #1176

Closed olivroy closed 5 months ago

olivroy commented 5 months ago

Also fixing some errors I introduced. When linking only to a help page, one should use topic, not help.

Also, I was wondering if it was possible to run styler, but only for quotes, i.e. changing '' to ""?

codecov-commenter commented 5 months ago

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (dbaa169) 92.16% compared to head (c315cf0) 92.16%.

:exclamation: Current head c315cf0 differs from pull request most recent head 4b999fb. Consider uploading reports for the commit 4b999fb to get more accurate results

Files Patch % Lines
R/parse.R 0.00% 4 Missing :warning:
R/addins.R 80.00% 1 Missing :warning:
R/transform-code.R 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1176 +/- ## ======================================= Coverage 92.16% 92.16% ======================================= Files 46 46 Lines 2655 2656 +1 ======================================= + Hits 2447 2448 +1 Misses 208 208 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 5 months ago

This is how benchmark results would change (along with a 95% confidence interval in relative change) if dbaa169c3552d400489bd15765f2de0a429fdbcb is merged into main:

Further explanation regarding interpretation and methodology can be found in the documentation.

olivroy commented 5 months ago

Thanks for your suggestion, I applied them + a couple extra things here and there!

github-actions[bot] commented 5 months ago

This is how benchmark results would change (along with a 95% confidence interval in relative change) if dbaa169c3552d400489bd15765f2de0a429fdbcb is merged into main:

Further explanation regarding interpretation and methodology can be found in the documentation.