r-lib / styler

Non-invasive pretty printing of R code
https://styler.r-lib.org
Other
724 stars 71 forks source link

Failure on R devel #1180

Closed lorenzwalthert closed 6 months ago

lorenzwalthert commented 6 months ago

Dear maintainer,

Please see the problems shown on https://cran.r-project.org/web/checks/check_results_styler.html.

Please correct before 2024-04-01 to safely retain your package on CRAN.

Best, -k

IndrajeetPatil commented 6 months ago

I guess it's this change in R-devel that is affecting the test?

The parser has been updated to work with \Ibison 3.8.2, which is now used for the pre-generated parsers in ‘gram.c’, ‘file.c’, and ‘gramRd.c’. A few parser error messages have changed, which may affect code that relies on exact messages.

lorenzwalthert commented 6 months ago

anyone wants to download R devel with https://github.com/r-lib/rig or other methods to fix the message? or can we get more test output from GitHub actions to fix the Snapshot?

MichaelChirico commented 6 months ago

anyone wants to download R devel with https://github.com/r-lib/rig or other methods to fix the message? or can we get more test output from GitHub actions to fix the Snapshot?

FWIW I fixed this issue in GitHub codespaces using a docker image: https://github.com/Rdatatable/data.table/blob/master/.devcontainer/r-devel-gcc/Dockerfile.

you might be able to shim your way to ferreting out the issues without r-devel by replacing `<` = \(x, y) if (is.language(x) != is.language(y)) stop("here") else base::`<`(x, y)

IndrajeetPatil commented 6 months ago

Please correct before 2024-04-01 to safely retain your package on CRAN.

Looks like CRAN has relaxed this deadline? Package is still not archived on CRAN.

lorenzwalthert commented 6 months ago

Yeah sorry I forgot to write here got an extension until April 8.

lorenzwalthert commented 6 months ago

styler fails pre-checks with

Changes to worse in reverse depends:

Package: shinymeta
Check: for code/documentation mismatches
New result: WARNING
 Error: package or namespace load failed for ‘shinymeta’:
  .onLoad failed in loadNamespace() for 'styler', details:
   call: value[[3L]](cond)
   error: No permission to create a new file in directory: /tmp/check-CRAN-incoming-hornik/cache/R/R.cache/styler
 Call sequence:
 6: stop(msg, call. = FALSE, domain = NA)
 5: value[[3L]](cond)
 4: tryCatchOne(expr, names, parentenv, handlers[[1L]])
 3: tryCatchList(expr, classes, parentenv, handlers)
 2: tryCatch({
        attr(package, "LibPath") <- which.lib.loc
        ns <- loadNamespace(package, lib.loc)
        env <- attachNamespace(ns, pos = pos, deps, exclude, include.only)
    }, error = function(e) {
        P <- if (!is.null(cc <- conditionCall(e)))
            paste(" in", deparse(cc)[1L])
        else ""
        msg <- gettextf("package or namespace load failed for %s%s:\n %s",
            sQuote(package), P, conditionMessage(e))
        if (logical.return && !quietly)
            message(paste("Error:", msg), domain = NA)
        else stop(msg
 Execution halted

Package: shinyobjects
Check: whether package can be installed
New result: ERROR
 Installation failed.

Which is very similar to 1.10.2 submission, that Uwe let pass for I don't know what reasons in the end. Kurt now wrote:

Afaict the styler subdir is mode 755.

Btw, it contains an 1.10.2 subdir apparently from today's revdep checks,
containing lots of file of size 0.  Not ideal ...

Perhaps the error indicates some race condition?

Best
-k

I replied:

Dear Kurt

I will get back to you later today. However, I am afraid I can’t meet the requested re-submission deadline of
tomorrow, in particular since the problem is hard to reproduce and it seems to be caused by the use of the
 R.cache package, which is not under my control. As mentioned before, a similar problem has occurred for the 
1.10.2 submission and Uwe sent styler to CRAN after the message I sent you you before. It was not apparent from 
my conversation with him how he resolved the problem (see conversation attached).
lorenzwalthert commented 6 months ago

I re-opened https://github.com/HenrikBengtsson/R.cache/issues/51.