r-lib / styler

Non-invasive pretty printing of R code
https://styler.r-lib.org
Other
703 stars 70 forks source link

Adjust to parser failures in r devel #1181

Closed lorenzwalthert closed 4 months ago

lorenzwalthert commented 4 months ago

First commit to try to reproduce the issue on GitHub Actions to make sure we resolve it. Closes #1180.

codecov-commenter commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.16%. Comparing base (20c5b37) to head (80a307c).

:exclamation: Current head 80a307c differs from pull request most recent head 89ea11a. Consider uploading reports for the commit 89ea11a to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1181 +/- ## ======================================= Coverage 92.16% 92.16% ======================================= Files 46 46 Lines 2654 2654 ======================================= Hits 2446 2446 Misses 208 208 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

lorenzwalthert commented 4 months ago

~Thought of this solution also. πŸ˜„ Then once we all use R 4.4, we can go back and activate the check again...~ Ok sorry missed that you actually fixed it. Good job!

lorenzwalthert commented 4 months ago

Do we still need upload-results: true? I just undid that but now not sure if that was a good idea.

IndrajeetPatil commented 4 months ago

I find it useful to have the check results available on CI, esp. for OS that I don't have personal access to (Windows).

lorenzwalthert commented 4 months ago

ok sorry then let's revert. But for my curiosity: You still needed to locally install R devel? Or did you manage to find the hint in the test results?

lorenzwalthert commented 4 months ago

Thanks a lot again @IndrajeetPatil.

IndrajeetPatil commented 4 months ago

Actually, I figured out the problem without downloading the devel version locally because the same issue was also present in one of the tests in lintr πŸ˜…

MichaelChirico commented 4 months ago

ok sorry then let's revert. But for my curiosity: You still needed to locally install R devel? Or did you manage to find the hint in the test results?

FWIW, in {data.table} we have an Codespace set up that we can easily log into from anywhere to check the package against r-devel:

https://github.com/Rdatatable/data.table/blob/master/.devcontainer/r-devel-gcc/Dockerfile

lorenzwalthert commented 4 months ago

Thanks @MichaelChirico. Is that a free plan? Maybe worth looking into, after the last 3 maintenance, I am sure the next parser change requiring a {styler} release is just around the corner.

MichaelChirico commented 4 months ago

Hmm I couldn't tell what exactly's free from a quick scan of the codespaces page:

https://github.com/features/codespaces

I get a fairly large amount of free time included with my normal $4/mo GitHub pro subscription. Even barring that, it would be free to run that Docker image locally, the advantage of Codespaces is I can do it in the browser from anywhere.

lorenzwalthert commented 4 months ago

I am fine billing the guys who set up the r-lib org 😜. Hehe no, I don’t know if the pricing works per user or per org.