Closed lorenzwalthert closed 4 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 92.16%. Comparing base (
20c5b37
) to head (80a307c
).:exclamation: Current head 80a307c differs from pull request most recent head 89ea11a. Consider uploading reports for the commit 89ea11a to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
~Thought of this solution also. π Then once we all use R 4.4, we can go back and activate the check again...~ Ok sorry missed that you actually fixed it. Good job!
Do we still need upload-results: true
? I just undid that but now not sure if that was a good idea.
I find it useful to have the check results available on CI, esp. for OS that I don't have personal access to (Windows).
ok sorry then let's revert. But for my curiosity: You still needed to locally install R devel? Or did you manage to find the hint in the test results?
Thanks a lot again @IndrajeetPatil.
Actually, I figured out the problem without downloading the devel version locally because the same issue was also present in one of the tests in lintr π
ok sorry then let's revert. But for my curiosity: You still needed to locally install R devel? Or did you manage to find the hint in the test results?
FWIW, in {data.table} we have an Codespace set up that we can easily log into from anywhere to check the package against r-devel:
https://github.com/Rdatatable/data.table/blob/master/.devcontainer/r-devel-gcc/Dockerfile
Thanks @MichaelChirico. Is that a free plan? Maybe worth looking into, after the last 3 maintenance, I am sure the next parser change requiring a {styler} release is just around the corner.
Hmm I couldn't tell what exactly's free from a quick scan of the codespaces page:
https://github.com/features/codespaces
I get a fairly large amount of free time included with my normal $4/mo GitHub pro subscription. Even barring that, it would be free to run that Docker image locally, the advantage of Codespaces is I can do it in the browser from anywhere.
I am fine billing the guys who set up the r-lib org π. Hehe no, I donβt know if the pricing works per user or per org.
First commit to try to reproduce the issue on GitHub Actions to make sure we resolve it. Closes #1180.