Revert "Add colored output"

r-lib / styler

Non-invasive pretty printing of R code

https://styler.r-lib.org

Other

703 stars 70 forks source link

Revert "Add colored output" #1191

Closed olivroy closed 1 month ago

olivroy commented 3 months ago

Reverts r-lib/styler#1187

github-actions[bot] commented 3 months ago

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 208d9c7abb4eb44436695a68a19ea979c99ce921 is merged into main:

:heavy_check_mark:cache_applying: 147ms -> 146ms [-2.76%, +1.37%]
:heavy_check_mark:cache_recording: 514ms -> 511ms [-1.21%, +0.25%]
:heavy_check_mark:without_cache: 982ms -> 985ms [-0.06%, +0.66%]

Further explanation regarding interpretation and methodology can be found in the documentation.

lorenzwalthert commented 3 months ago

Thanks. Let’s wait with merge because I am not yet fully convinced we should. More later…

lorenzwalthert commented 3 months ago

@olivroy to follow up, see my last comment https://github.com/r-lib/styler/pull/1189#issuecomment-2035311313. Hence, I'd still consider your contribution valuable. Alternatively, we can think more fundamentally about how the R CLI for {styler} could improve. If you see yourself making contributions there, let's first discuss in an issue and then you can implement them if you want. But no pressure, either merging this or #1189 would also be fine for me.

olivroy commented 3 months ago

Ok, yeah I see, maybe #1189 would be fine. Sacrifice a single mis-alignment for the greater good may be a good idea?