r-lib / styler

Non-invasive pretty printing of R code
https://styler.r-lib.org
Other
724 stars 71 forks source link

Update spelling wordlist #1210

Closed IndrajeetPatil closed 4 months ago

IndrajeetPatil commented 4 months ago

via spelling::update_wordlist()

github-actions[bot] commented 4 months ago

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 4f782529e2419471d9abcf60899bf28a34bd5268 is merged into main:

Further explanation regarding interpretation and methodology can be found in the documentation.

lorenzwalthert commented 4 months ago

I did not know about spelling::update_wordlist(). Maybe the pre-commit hook should use it instead of a custom logic that only adds words and never removes words when the --read-only flag is absent. Interested in a PR there? 😀

IndrajeetPatil commented 4 months ago

Yes, I can update precommit to use spelling package in a separate PR.

IndrajeetPatil commented 4 months ago

I did not know about spelling::update_wordlist(). Maybe the pre-commit hook should use it instead of a custom logic that only adds words and never removes words when the --read-only flag is absent. Interested in a PR there? 😀

I created an issue upstream so that everyone can benefit from these changes, and not just {styler}:

https://github.com/lorenzwalthert/precommit/issues/572

Either I or someone else can work on it if you can't.