Remove unused testing helper: `generate_test_samples()`

r-lib / styler

Non-invasive pretty printing of R code

https://styler.r-lib.org

Other

703 stars 70 forks source link

Remove unused testing helper: `generate_test_samples()` #1212

Closed IndrajeetPatil closed 2 months ago

github-actions[bot] commented 2 months ago

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 4f782529e2419471d9abcf60899bf28a34bd5268 is merged into main:

:heavy_check_mark:cache_applying: 152ms -> 155ms [-3.81%, +6.79%]
:heavy_check_mark:cache_recording: 547ms -> 542ms [-5.51%, +3.92%]
:heavy_check_mark:without_cache: 943ms -> 939ms [-0.73%, +0.03%]

Further explanation regarding interpretation and methodology can be found in the documentation.

lorenzwalthert commented 2 months ago

Hmmmm... Not sure we actually want to remove these functions. I think Kirill deliberately committed these generators, not sure maybe he thought we'd later change them later to re-generate tests. Hasn't happened though... I guess we can remove them, and come back here in case we need them.