r-lib / styler

Non-invasive pretty printing of R code
https://styler.r-lib.org
Other
724 stars 71 forks source link

Check for warnings in examples #1219

Open IndrajeetPatil opened 3 months ago

IndrajeetPatil commented 3 months ago

@lorenzwalthert We can either do this and/or add a new workflow from lintr that runs tests in strict mode.

I prefer doing both, but wanted to first check with you.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.57%. Comparing base (7b5327c) to head (e19bc2c).

:exclamation: Current head e19bc2c differs from pull request most recent head 27a07d5

Please upload reports for the commit 27a07d5 to get more accurate results.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1219 +/- ## ======================================= Coverage 91.57% 91.57% ======================================= Files 46 46 Lines 2647 2647 ======================================= Hits 2424 2424 Misses 223 223 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

lorenzwalthert commented 3 months ago

I also prefer both 👍.

lorenzwalthert commented 3 months ago

Do we really need a separate workflow or can we incorporate it an existing one? I try to limit compute time.