Do not use external_pointer class in function signatures

r-lib / svglite

A lightweight svg graphics device for R

https://svglite.r-lib.org

180 stars 39 forks source link

Do not use external_pointer class in function signatures #112

Closed jimhester closed 4 years ago

jimhester commented 4 years ago

The external pointer is around a std::stringstream and that header won't be included automatically in cpp11-exports.cpp.

I think the best way forward s to avoid putting that class in the exported function signature. This requires you to do the conversions within the function, but that seems only a minor inconvenience.

thomasp85 commented 4 years ago

Away from computer now, but does having a svglite_types.h file allow ingesting includes etc into cpp11-exports in the same way as with rcpp?