search

r-lib / svglite

A lightweight svg graphics device for R
https://svglite.r-lib.org
180 stars 39 forks source link

add path() device function #37

Closed yixuan closed 9 years ago

yixuan commented 9 years ago

This PR adds the path() device function to devSVG(), so that it can support the R function polypath(), and the showtext package can render fonts properly on this device.

codecov-io commented 9 years ago

Current coverage is 91.96%

Merging #37 into master will increase coverage by +0.56% as of 4ffca9a

@@            master     #37   diff @@
======================================
  Files            6       6       
  Stmts          291     311    +20
  Branches         0       0       
  Methods          0       0       
======================================
+ Hit            266     286    +20
  Partial          0       0       
  Missed          25      25

Review entire Coverage Diff as of 4ffca9a

Powered by Codecov. Updated on successful CI builds.

hadley commented 9 years ago

This looks great! Would you mind adding a unit test?

yixuan commented 9 years ago

No problem. I can create a new patch including the unit test.

yixuan commented 9 years ago

It seems that the check stops at installing the covr package. Is there any possible reason for this?

hadley commented 9 years ago

Sometimes travis is just flakey :(

hadley commented 9 years ago

Looks great. One last thing: can you please add a bullet point to NEWS?

yixuan commented 9 years ago

Sure. An entry has been added.

hadley commented 9 years ago

Thanks!

timelyportfolio commented 9 years ago

This is great. I just tried the new path on the previously not-working-with-RSvgDevice tmap package, and it works perfectly. Thanks so much!

yixuan commented 9 years ago

You are welcome. :-)