search

r-lib / svglite

A lightweight svg graphics device for R
https://svglite.r-lib.org
180 stars 39 forks source link

Support line end and line join styles #38

Closed yixuan closed 9 years ago

yixuan commented 9 years ago

This patch will generate line end and line join attributes when setting line styles, if the values are different from default. (https://github.com/mdecorde/RSvgDevice/issues/24)

codecov-io commented 9 years ago

Current coverage is 92.37%

Merging #38 into master will increase coverage by +0.41% as of 91bd649

@@            master     #38   diff @@
======================================
  Files            6       6       
  Stmts          311     328    +17
  Branches         0       0       
  Methods          0       0       
======================================
+ Hit            286     303    +17
  Partial          0       0       
  Missed          25      25

Review entire Coverage Diff as of 91bd649

Powered by Codecov. Updated on successful CI builds.

yixuan commented 9 years ago

OK, if needed I could provide a small patch later based on your comments.

hadley commented 9 years ago

BTW do you know that a PR basically tracks a branch? So if you push more commits into that branch, the PR will update automatically

yixuan commented 9 years ago

Actually I didn't know about this feature. Thanks for pointing out! Does it still work once you have merged the PR?