search

r-lib / testthat

An R 📦 to make testing 😀
https://testthat.r-lib.org
Other
869 stars 313 forks source link

Align with `withr::local_language()` from dev withr #1879

Open krlmlr opened 8 months ago

krlmlr commented 8 months ago

Otherwise tests show warnings for me.

krlmlr commented 8 months ago

Confirming that this fixes my problems with dev withr: https://github.com/r-dbi/RMariaDB/pull/305/commits/9e1f5d1631c39fef6ff6ee74f3dbe85f5ed2da6c.

I wonder why testthat's own tests fail now.

lionel- commented 8 months ago

Maybe you need to adjust the tests like this? https://github.com/r-lib/withr/commit/08619ef7cca6ee4b01adf3d56fdebf366656ec89

krlmlr commented 8 months ago

Tried a moonshot, but could you please take this on (fixing tests if needed, NEWS, ...)?

hadley commented 4 months ago

@lionel- can you take another look at this please?