Using `skip_if_offline()` when curl is not installed results in a confusing error

r-lib / testthat

An R 📦 to make testing 😀

https://testthat.r-lib.org

Other

869 stars 313 forks source link

Using `skip_if_offline()` when curl is not installed results in a confusing error #1880

Closed paleolimbot closed 8 months ago

paleolimbot commented 8 months ago

After https://github.com/r-lib/testthat/pull/1866 , we get the following in Arrow's CI: https://github.com/apache/arrow/actions/runs/6455470463/job/17523978571?pr=38002#step:10:23987

-- Error ('test-parquet.R:485:3'): Can read Parquet files from a URL -----------
Error in `paste0("The ", pkg, " package must be installed in order to use `", 
    fun, "`")`: argument "fun" is missing, with no default

I imagine this was not the intended error message for this case!

paleolimbot commented 8 months ago

For reference, the Arrow issue was https://github.com/apache/arrow/issues/38138 (which we fixed by installing curl, as we should have all along!)

hadley commented 8 months ago

Doh